-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Filter Docs #714
Fix Filter Docs #714
Conversation
@@ -0,0 +1,16 @@ | |||
::: valor.schemas.Gte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could all of the "Conditions" exist on one page, and all of the "Logic" on another, rather than having a separate page for each individual class? in this setup, it seems like it would take a lot of clicking between pages for a user to figure out what to use. some of the docs for these classes (like most of the "Conditions") are also very barebones, so it seems odd to break them out separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that format is visually confusing, but it's weird that you're mixing operators (Gt, Gte, etc.) with other stuff (Condition, Function) under a header called "Operators". maybe move these latter two docstrings into Filter or another category?
Changes