move php-cs-fixer into the org

[braver]

The original repo has been dead for quite a while. I forked it into the org, and pulled in all the work @gerardroche has done.

[kaste]

You didn't clone the tags, dude.

[kaste]

Are you using this?. Well, apparently.

The split_match looks strange

    def split_match(self, match):
        """Extract and return values from match."""
        match, line, col, error, warning, message, near = super().split_match(match)

        line = line + 3
        message = "php-cs-fixer error(s) - " + message

        return match, line, col, error, warning, message, near

It prepends the linter name to each message. Also line is mangled with a constant. We have line_col_base = (1, 1) for that, no?

There is also a fallback

https://github.com/SublimeLinter/SublimeLinter-php-cs-fixer/blob/8f4d64ae915a3ba31f8918da3247b3415e0417ac/linter.py#L83-L85

            config_file = _find_configuration_file(self.view.file_name())
            if not config_file:
                config_file = self.config_file

but self.config_file should not be an attribute. This should raise in practice.

[braver]

You didn't clone the tags, dude.

Ah, rookie mistake, sorry.

Are you using this?

It's been sitting on my work computer with gerardroche's patches applied for over a year and it looks like it works. So, I never really looked at it before (and finally getting around to publishing it properly here was a rush job too as you noticed). Except for those patches the bones of the linter plugin are 8 years old so I bet it's weird in places. Maybe I can find a few minutes between meetings to look at it later this week.