Extend unit testing for elo-ranking #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moliholy
reviewed
Aug 31, 2023
src/tests.rs
Outdated
| @@ -534,7 +534,51 @@ fn check_elo_stronger_looses() { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn check_elo_player_aborts() { | |||
| fn check_elo_player_draw() { | |||
There was a problem hiding this comment.
I think in English it's "draws", in plural.
Moliholy
reviewed
Aug 31, 2023
src/tests.rs
Outdated
|
|
||
| // check elo before the match finishes | ||
| assert_eq!(Chess::player_elo(charlie), 1000); | ||
| assert_eq!(Chess::player_elo(dave), 1000); |
There was a problem hiding this comment.
If both players have the same ELO and make draws then they maintain the same ELO, that's correct. However, in the previous example it checked what happens if they have different ELO, which I think it's interesting to maintain.
There was a problem hiding this comment.
You are totally right, it makes more sense your approach to see is changing. Revert it in this commit 7d2c849
src/tests.rs
Outdated
| System::block_number() + <Test as Config>::BulletPeriod::get() + 1, | ||
| ); | ||
|
|
||
| // Bob abandom, alice claims victory |
Moliholy
approved these changes
Sep 1, 2023
|
Looks good to me. I however can't trigger the merge when the CI passes 😞 |
|
@Moliholy just added you as a contributor to the repo, let me know if you got the invite. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the name of the test
check_elo_player_abortswithcheck_elo_player_drawbecause what is actually testing is the scenario of a draw (I change the players ELO ranking too, but just for testing purposes).I add a test
check_elo_stronger_abandonwhere the stronger player abandon and therefore loses to see if in case of abandom the ELO ranking is updating property too.