Refine narrator removal logic in ShouldRemoveNarrator method #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted string checks to improve consistency and accuracy in narrator removal. Added "https" to URL detection and standardized case matching for specific phrases. This enhances reliability across different input variations. Signed-off-by: Ivandro Jao <[email protected]>
ivandrofly
commented
Feb 10, 2025
| "Previously on", | ||
| "Improved by", | ||
| "previously on", | ||
| "improved by", |
ivandrofly
commented
Feb 10, 2025
| @@ -817,15 +817,15 @@ private static bool IsInsideBrackets(string text, int targetIndex) | |||
|
|
|||
| private static bool ShouldRemoveNarrator(string pre, string language) | |||
| { | |||
| if (pre.Length > 30 || pre.IndexOfAny(new[] { "http", ", " }, StringComparison.OrdinalIgnoreCase) >= 0) | |||
| if (pre.Length > 30 || pre.IndexOfAny(new[] { "http", "https", ", " }, StringComparison.OrdinalIgnoreCase) >= 0) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted string checks to improve consistency and accuracy in narrator removal. Added "https" to URL detection and standardized case matching for specific phrases. This enhances reliability across different input variations.