Add ability to show files per build and whitelisting #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sude-
reviewed
Apr 1, 2024
Sude-
reviewed
Apr 1, 2024
| for (int i = 0; i < items.size(); i++) { | ||
| json_items[i]["product_id"] = items[i].product_id; | ||
| json_items[i]["path"] = items[i].path; | ||
| json_items[i]["size"] = static_cast<unsigned int>(items[i].totalSizeUncompressed); |
There was a problem hiding this comment.
Is unsigned int big enough?
Perhaps std::uintmax_t would be better.
There was a problem hiding this comment.
yeah, it is an std::uintmax_t internally — but for some reason, Json::Value has multiple overloads for the type, so I was forced to cast it
There was a problem hiding this comment.
I also wanted to use a size_t for the loop itself, but it freaks out because their indexing operator seems to be overidded on multiple sizes or something
|
This PR expanded in scope as I added whitelisting capabilities, which I need for my use-case. More than happy to split up into another PR if desired. |
abhiaagarwal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to show the files associated with a build in stdout. Useful for doing any pre-processing via
jqbefore actually downloading the build.Additionally adds a whitelisting capability. It uses the exact same logic as
Blacklist(which has been renamed toFilelistto represent that it's more generic, but the same logic). I made it so that the whitelist takes precedent over the blacklist, but this can be changed as desired.