Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All 1.2 #119

Merged
merged 14 commits into from
Jul 23, 2024
Merged

All 1.2 #119

merged 14 commits into from
Jul 23, 2024

Conversation

gouravmore
Copy link
Member

@gouravmore gouravmore commented Jul 23, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a logout functionality with a user-friendly interface.
    • Enhanced routing logic for better user authentication handling.
  • Improvements

    • Streamlined component structure and improved styling for consistency.
    • Modified deployment branch and environment variable for improved configuration management.
  • Bug Fixes

    • Adjusted control flow in the application based on the presence of user authentication status.

@gouravmore gouravmore merged commit 05c4ef9 into all-1.1 Jul 23, 2024
1 check passed
Copy link

coderabbitai bot commented Jul 23, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes involve modifications to environment variables in GitHub Actions workflows, specifically shifting from REACT_APP_IS_APP_TEST_RIG to REACT_APP_IS_IN_APP_AUTHORISATION. This adjustment impacts application authorization logic. Additionally, enhancements were made to the Assesment.jsx component, including a new logout function and improved user interface elements. Routing logic was also refined to conditionally handle user authentication, while telemetry service data collection was expanded to include user agent information.

Changes

Files Change Summary
.github/workflows/all-*.yml Environment variable REACT_APP_IS_APP_TEST_RIG replaced with REACT_APP_IS_IN_APP_AUTHORISATION. Deployment branch changed from test-rig-1.1 to all-1.2.
src/components/Assesment/Assesment.jsx Added a handleLogout function, new styled components for logout UI, and conditional rendering of the logout button. Improved layout and navigation logic.
src/routes/index.js Introduced isLogin variable to check user authentication and modified routing logic based on the presence of virtualId.
src/services/telementryService.js Updated start function to include dspec property in the fetch request, capturing user agent data.
src/views/AppContent/AppContent.jsx Changed PrivateRoute to retrieve virtualId directly from local storage instead of Redux, improving authentication handling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants