Fix unique index creation error for schemas added via API #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejash-jl
reviewed
Jun 21, 2023
java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryEntityController.java
Outdated
Show resolved
Hide resolved
tejash-jl
changed the title
|
made changes in PR and update the PR |
varadeth
suggested changes
Jun 30, 2023
java/registry/src/main/java/dev/sunbirdrc/registry/service/impl/RegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/service/impl/RegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
…reated # Conflicts: # java/pojos/src/main/java/dev/sunbirdrc/pojos/Response.java # java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryEntityController.java # java/registry/src/main/java/dev/sunbirdrc/registry/util/EntityParenter.java # java/registry/src/test/java/dev/sunbirdrc/registry/controller/RegistryEntityControllerTest.java
srprasanna
reviewed
Jul 5, 2023
java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryEntityController.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryEntityController.java
Outdated
Show resolved
Hide resolved
|
Formating done and push the PR again |
|
resolve conversation marked |
holashchand
suggested changes
Oct 11, 2023
java/registry/src/test/java/dev/sunbirdrc/registry/controller/RegistryEntityControllerTest.java
Outdated
Show resolved
Hide resolved
|
Closing as this issue was fixed in this pr - #318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index is created without restart the registry iafter the schema is created successfully.
And UniIndexFields is also added and working successfully