Add script-enforced strategies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the notion of script-guarded strategies.
In addition to the ability to delegate a strategy to a verification key, you can instead specify a script that must be present on the scoop transaction to enact the strategy.
A scooper would need to be aware to attach this script, but it would allow us to extend the protocol arbitrarily; users could attach scripts to check the correctness of the execution, rather than only relying on verification keys.
This could, for example, be used to check that the price was within a certain range before trading; or that only deposits and withdrawals were supported, not swaps, etc.
To facilitate these scripts, we also add an arbitrary "Extensions" field to pack extra data in the strategy execution that the script could inspect.