Resolve SSW-203 #56
Merged
Resolve SSW-203 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pool with negative fees would slowly drain its reserves with each trade; there may be use cases for this, but we haven't thought through the implications, and so prevent it in this version of the pool script. A pool with fees greater than 10,000 would never be able to execute, or would be vulnerable to some other major flaw. We allow pools with 0% fees and with 100% fees, as they are safe from the protocol perspective, and someone in the ecosystem may have a creative use for these values. However, we strongly recommend anyone building UIs that interface with the protocol display a strong warning if the pool fee is above some percentage threshold.
|
LGTM, solves SSW-203 |
francolq
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pool with negative fees would slowly drain its reserves with each
trade; there may be use cases for this, but we haven't thought through
the implications, and so prevent it in this version of the pool script.
A pool with fees greater than 10,000 would never be able to execute, or
would be vulnerable to some other major flaw.
We allow pools with 0% fees and with 100% fees, as they are safe from
the protocol perspective, and someone in the ecosystem may have a
creative use for these values. However, we strongly recommend anyone
building UIs that interface with the protocol display a strong warning
if the pool fee is above some percentage threshold.