Resolve SSW-308 #60
Merged
Resolve SSW-308 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check that the settings NFT is paid into the settings script with a valid datum; this isn't strictly neccesary, because we can just say the protocol is only valid if this happens correctly, but it does help for an inductive base case.
francolq
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Looks good. It solves SSW-308 to a great extend, by checking that the settings UTxO is created with a value that includes the settings NFT token and a datum that is compatible with the SettingsDatum type.
No checks are done on other aspects of the value, so garbage tokens can be included, but we don't consider this an issue.
Also, it could be possible to check for some datum fields, for instance to have correct range of values for base_fee, simple_fee and strategy_fee. I also consider this as completely optional and only if an extremely pedantic validation is wanted.
|
I'm going to skip tests on this one, as it's largely cosmetic minting checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check that the settings NFT is paid into the settings script with a
valid datum; this isn't strictly neccesary, because we can just say the
protocol is only valid if this happens correctly, but it does help for
an inductive base case.