Resolve SSW-201 #66
Merged
Resolve SSW-201 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking:
- original version
34 => { cpu: 5238830255, mem: 13459313 },
35 => { cpu: 5367257843, mem: 13789894 }
- optimized version
34 => { cpu: 5222871729, mem: 13414480 },
35 => { cpu: 5356877915, mem: 13757945 }
Savings:
- for 34 orders: 15.958.526 cpu and 44.833 mem
- for 35 orders: 10.379.928 cpu and 31.949 mem
…s part of the pair
…ected_pool_value-optimization
Building off @ignaciodopazo's pr to optimize has_expected_pool_value, we can just use that implementation to fix SSW-201 The mint contract would fail when ADA was not one of the pairs, because we were checking that the number of tokens was 3.
ignaciodopazo
approved these changes
Mar 5, 2024
rrruko
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When minting a pool, we were checking that the number of assets on the output was 3 or less.
The idea here being that the output would contain ADA, Asset B, and the Pool NFT.
However, this prevented exotic pairs (like SUNDAE/WMT) from being minted.
This resolves it by reusing @ignaciodopazo's more efficient has_expected_pool_value to check for the correct output pool value. It also adds a test case for this, which was originally written against the unfixed branch to confirm it fails, then moved to this branch to confirm it passes.