Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a variable with a counter for all the vertices on the foil #26

Closed
pfranchini opened this issue Jan 24, 2020 · 1 comment
Closed

Implement a variable with a counter for all the vertices on the foil #26

pfranchini opened this issue Jan 24, 2020 · 1 comment

Comments

@pfranchini
Copy link
Contributor

The current variable reco.vertices_on_foil counts either vertices on foil or on wire, so the name is a bit misleading (or at least was for me).

The idea is

  • renaming this one (so people using this variable for the wrong purpose will spot it out updating the code)
  • creating a new one like reco.foil_vertex_count (similar of reco.calorimeter_hit_count) counting the vertices on the foil for each event
  • update the README.md

This has been discussed in SuperNEMO-DBD/Falaise#142.
@pfranchini pfranchini mentioned this issue Jan 27, 2020
Merged
@pfranchini pfranchini mentioned this issue May 18, 2020
Merged
@cherylepatrick
Copy link
Collaborator

cherylepatrick commented Jun 16, 2020 •
edited
Loading

Fixed by #27

pfranchini added a commit to pfranchini/SensitivityModule that referenced this issue Dec 18, 2020
@pfranchini
Fixed the variables used to identify if the vertex was on the foil on…
79155d5 
…ly for electrons and alphas, where was left untouched, and wrong, from issue SuperNEMO-DBD#26
@pfranchini pfranchini mentioned this issue Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cherylepatrick @pfranchini