Skip to content

Remove root and instance_options for active model serializers 1.0.x compatability#137

Open
nikolai-b wants to merge 1 commit into
Sutto:masterfrom
nikolai-b:active-model-serializers
Open

Remove root and instance_options for active model serializers 1.0.x compatability#137
nikolai-b wants to merge 1 commit into
Sutto:masterfrom
nikolai-b:active-model-serializers

Conversation

@nikolai-b
Copy link
Copy Markdown

Very sorry this has no specs 😞
With the new https://github.com/rails-api/active_model_serializers version was failing with

       Diff: 

       @@ -1,6 +1,6 @@
       -"instance_options" => {},
       +"instance_options" => {"url_options"=>{"host"=>"test.host", "port"=>nil, "protocol"=>"http://", "_recall"=>{"version"=>"1", "controller"=>"...", "action"=>"..."}, "version"=>"1"}, "root"=>false, "singular"=>true},
        "object" => {"id"=>1, ...},
       -"root" => nil,
       +"root" => false,
        "scope" => nil,
        "url" => nil,

There is probably a more elegant way of doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant