Use new ActiveModel::SerializableResource#138
Open
nikolai-b wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
coming here from: rails-api/active_model_serializers#1321 (comment)
could be a little more efficient by just defining a different method per version
if ActiveModel::Serializer::VERSION.start_with?('0.9.')
def serializable_hash(options = {})
instance = serializer.new(object, options)
if instance.respond_to?(:serializable_hash)
instance.serializable_hash
else
instance.as_json options
end
end
elsif ActiveModel::Serializer::VERSION.start_with?('0.10.')
defined?(ActiveModel::SerializableResource) or fail "Your ActiveModelSerializers is too old. Please update to the latest minor or patch release."
def serializable_hash(options = {})
ActiveModel::SerializableResource.new(object, options.merge(serializer: serializer)).serializable_hash
end
else
fail ArgumentError, "We don't know how to serialize in #{ActiveModel::Serializer::VERSION}"
endThere was a problem hiding this comment.
This stems partly from the super loose constraint in the Gemfile
gem 'active_model_serializers', ENV['AMS_VERSION'] || '> 0.0'(I'm guessing it's a soft dependency?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as_jsondoes not work with the newest version of https://github.com/rails-api/active_model_serializers and it is suggested that you use theActiveModel::SerializableResourceclass.