Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style #434

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sbol2/property.py
Original file line number Diff line number Diff line change
Expand Up @@ -935,9 +935,8 @@ def __init__(self, property_owner, type_uri, reference_type_uri,
super().__init__(property_owner, type_uri, lower_bound, upper_bound,
validation_rules, initial_value)
self.reference_type_uri = reference_type_uri
if self._sbol_owner is None:
property_store = []
self._sbol_owner.properties[type_uri] = property_store
property_store = []
self._sbol_owner.properties[type_uri] = property_store

def get(self, item):
"""Return reference object at this index.
Expand Down
1 change: 0 additions & 1 deletion test/test_participation.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def test_add_remove_role(self):
self.assertEqual([sbol2.SO_PROMOTER, sbol2.SO_CDS], p.roles)

def test_init_with_participant(self):

p = sbol2.Participation('p', participant='p1')
self.assertEqual('p1', p.participant)

Expand Down
2 changes: 1 addition & 1 deletion test/test_style.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_wildcard_imports(self):
if 'import' in line:
if '*' in line and 'constants' not in line:
msg = 'Wildcard import in {}: {}'
msg = msg.format(f, line)
_ = msg.format(f, line)
# self.fail(msg)
# print(msg)
wildcard_count += 1
Expand Down
Loading