WPF-955409-Need to fix the custom actions issue in the History manager sample #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
The Custom actions (FontFamily changing, FontSize changing, Annotation Color Changing, and FillColor Changing) are not updated in the Undo Stack.
Root cause
Codes are not implemented at the sample level.
Reason for not identifying earlier
Customers are not reporting these issues.
Is it a breaking issue?
No
Action taken
I have created the HistoryEntry in the sample level and added the Custom actions into the UndoElements. Push this History entry into the UndoStack. Also updated the Mode, GroupId, and Action for these Custom actions in the sample level.
Solution description
I have created the HistoryEntry in the sample level and added the Custom actions into the UndoElements. Push this History entry into the UndoStack. Also updated the Mode, GroupId, and Action for these Custom actions in the sample level.
Output details
Areas affected and ensured
No areas are affected
Additional checklist