Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for v9 SQL creation and connection #35

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

FergusMok
Copy link
Contributor

@FergusMok FergusMok commented Mar 20, 2024

Closes #34.

  1. Separated VPC connectors into it's own section
  2. Added section for SQL creation, connection, debugging and minimum-privileged user.
  3. Updated some missing parts and removed deprecated APIs.

@FergusMok FergusMok requested a review from wkurniawan07 March 20, 2024 05:34
@FergusMok FergusMok self-assigned this Mar 20, 2024
@@ -29,7 +31,8 @@ Note: This document does not have preference over either GAE standard or flexibl
1. Enable the following APIs in your project:
- [Cloud Tasks API](https://console.cloud.google.com/apis/library/cloudtasks.googleapis.com)
- [Cloud Scheduler API](https://console.cloud.google.com/apis/library/cloudscheduler.googleapis.com)
- [Cloud Debugger API](https://console.cloud.google.com/apis/library/clouddebugger.googleapis.com)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +66 to +67
# Creates the application on GCP
gcloud app create
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to create first, otherwise appengineDeployAll will fail

@FergusMok
Copy link
Contributor Author

Hi @wkurniawan07, I've added the portion on creating the user with minimum privileges.

For the remaining portion on data migrations (creation, edit) and changelogs using Liquibase, it'll be followed up in a future PR by @NicolasCwy

Copy link

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting up the docs!

@ziqing26 ziqing26 merged commit 1c75283 into TEAMMATES:master Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V9 Migration SQL Creation and Connection Documentation
3 participants