[TOP-107] 메인화면 타이머 개선 #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 1초마다 state를 update해줘서 다음 animation을 실행하는 방식에서 문제가 발생한것으로 추측 - maxSec, duration만 전달해서 전체 progress에 대한 animation을 한번에 수행
- 불필요한 속성 제거 - ToHotState에서 list가 아닌 단일 객체로 관리(현재 visible한 Card의 TimerState를 표시)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain this Pull Request 🙏
What has changed? 🤔
Screenshot 📸
Test Checklist 🚩