Optimize (and fix in some places) shared module detection #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
****What's this Pull request about?
Optimize (and fix in some places) shared module detection
****Does this pull request maintain backward compatibility?
Yes
****How this pull request has been tested?
Compare output of a build (logs and ear) for a build before optimization and after.
****Any background context or comments you want to provide?
In file Source/bw6-maven-plugin/src/main/java/com/tibco/bw/maven/plugin/application/BWEARPackagerMojo.java, line 184, the "containsKey" method is not working well because expect to search by an object of type Attributes.Name (https://docs.oracle.com/javase/7/docs/api/java/util/jar/Attributes.Name.html) not a string.