-
Notifications
You must be signed in to change notification settings - Fork 21
base-chart-promotion_1_13 & README change #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces the new tibco-cp-base Helm chart version 1.13, establishing a foundational umbrella chart for the TIBCO Platform Control Plane. The changes include new chart structures, subcharts for core services (identity-provider, identity-management, cronjobs), finops capabilities (monitoring-service), and configuration management (tp-cp-configuration). The PR also adds documentation, licensing, packaging hygiene via .helmignore files, and CRDs for advanced networking.
Reviewed changes
Copilot reviewed 194 out of 396 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| identity-provider chart files | New subchart providing identity provider service with deployment, service, HPA, and TibcoRoute configurations |
| identity-management chart files | New subchart for identity management including StatefulSet deployment, extensive routing configuration, and Fluent Bit logging |
| cronjobs chart files | New subchart for scheduled jobs with comprehensive database and service integrations |
| tp-cp-core-finops charts | New finops capabilities including monitoring-service with StatefulSet, recipes for infrastructure capabilities |
| tp-cp-configuration files | Configuration management chart with resource set templates, TibcoClusterEnv CRDs, and capability recipes |
| LICENSE files | Apache 2.0 licensing added to multiple chart levels |
| .helmignore files | Packaging hygiene files to exclude unnecessary content from Helm packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/tibco-cp-base/charts/tp-cp-core-finops/charts/monitoring-service/templates/_shared.tpl
Show resolved
Hide resolved
charts/tibco-cp-base/charts/tp-cp-core-finops/templates/app-secrets.yaml
Show resolved
Hide resolved
charts/tibco-cp-base/charts/tp-cp-core-finops/templates/logserver-secrets.yaml
Show resolved
Hide resolved
charts/tibco-cp-base/charts/tp-cp-core-finops/templates/recipe-script.yaml
Show resolved
Hide resolved
7a812ed to
5f2a9fb
Compare
5f2a9fb to
fe3b409
Compare
This pull request introduces the new
tibco-cp-baseHelm chart, providing a foundational chart for the TIBCO Platform with clear documentation, licensing, and dependency management. It also adds thehybrid-proxysubchart, including its own Helm metadata and a new Kubernetes CustomResourceDefinition (CRD) for tunnel routes. Additionally, the documentation is updated to clarify prerequisites and secret management, and Helm ignore files are added for better packaging hygiene.New Chart Introduction and Structure:
tibco-cp-baseHelm chart, including its main metadata (Chart.yaml), detailed documentation (README.md), and licensing information (LICENSE). This chart aggregates and manages dependencies for core TIBCO Platform components. [1] [2] [3]Dependency and Subchart Management:
tibco-cp-base/Chart.yamlfor various subcomponents, ensuring they are properly versioned and conditionally enabled.hybrid-proxysubchart with its ownChart.yaml,.helmignore, and a CRD for tunnel routes, allowing for advanced network routing configurations within the platform. [1] [2] [3]Documentation and Usability Improvements:
README.mdfortibco-cp-basedescribing required Kubernetes secrets, configuration options, and example commands to help users set up the chart correctly.README.mdto require Helm v3.14.0 or newer, ensuring compatibility and up-to-date features.Packaging and Licensing Hygiene:
.helmignorefiles to bothtibco-cp-baseand itshybrid-proxysubchart to exclude unnecessary files from Helm packages, improving build cleanliness. [1] [2]LICENSEfile fortibco-cp-base, clarifying legal terms for use and distribution.