Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing/145 그리기 도구 수정 #154

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Publishing/145 그리기 도구 수정 #154

merged 6 commits into from
Aug 12, 2024

Conversation

Hj1218
Copy link
Member

@Hj1218 Hj1218 commented Aug 10, 2024

PR type

  • Bug fix
  • Feature
  • Refactor
  • Chore
  • Publishing

💻 작업사항

  • 내용에 맞춰 컬러피커 모달 height fit 조정
  • 모달 뒷배경 스크롤 막기
  • 모달 닫는 버튼 추가
  • 도구팔레트 토글 반응형추가

💡 작성한 이슈 외에 작업한 사항

  • 불필요한 코드 삭제

✔️ check list

  • 작성한 이슈의 내용을 전부 적용했나요?
  • 리뷰어를 등록했나요?

@Hj1218 Hj1218 self-assigned this Aug 10, 2024
@Hj1218 Hj1218 linked an issue Aug 10, 2024 that may be closed by this pull request
4 tasks
className="text-[#6100C1] font-semibold text-lg md:text-2xl w-full text-end pr-4 pt-2 md:pt-4"
onClick={() => setColorPickerOpen(false)}
>
취소
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

취소 말고 그냥 X 표시로 두는 건 어떨까요..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정할게용

@heedong12
Copy link
Contributor

색상 선택 슬라이더랑 투명도 조절 슬라이더 사이 간격
색상 선택 부분과 아래 슬라이더 영역 분리(선 추가?)
이 부분도 추가해주실 수 있나여..??

Copy link
Member

@Leewonchan14 Leewonchan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사진 추가 해 주세용

@Hj1218 Hj1218 requested a review from Leewonchan14 August 11, 2024 11:33
@Hj1218 Hj1218 requested a review from heedong12 August 11, 2024 11:51
@Hj1218
Copy link
Member Author

Hj1218 commented Aug 11, 2024

@heedong12 @Leewonchan14 추가했습니다!

Copy link
Member

@Leewonchan14 Leewonchan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

직접 css를 만지는게 좀 아쉽긴 하네요

일단 굳 👍

Copy link
Contributor

@heedong12 heedong12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hj1218 Hj1218 merged commit e2cd144 into develop Aug 12, 2024
1 check passed
@Hj1218 Hj1218 deleted the publishing/145 branch August 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[publishing] 그림 그리기 도구 수정
3 participants