Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Remove ssl_certificates cookbook dependency #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove ssl_certificates cookbook dependency #15

wants to merge 1 commit into from

Conversation

brk3
Copy link

@brk3 brk3 commented Apr 8, 2014

It's now up to the user to get their certificates onto the target system
however they see fit.

We just need three attributes; 'ssl_keyfile_path', 'ssl_certfile_path',
and optionally 'ssl_cabundle_path'.

Fixes Issue #10

It's now up to the user to get their certificates onto the target system
however they see fit.

We just need three attributes; 'ssl_keyfile_path', 'ssl_certfile_path',
and optionally 'ssl_cabundle_path'.

Fixes Issue #10
@StephenKing
Copy link
Member

Thanks for that!

As far as I remember, most cookbooks require the path to the certificates to be set below their own attribute hierarchy, like node[:gerrit][:ssl_certificates] instead of node[:ssl_certificates].

What do you think of that?

@brk3
Copy link
Author

brk3 commented Apr 16, 2014

Sounds fine Stephen, I'll make an update.

@StephenKing
Copy link
Member

Fine. Do you think node[:gerrit][:ssl_certificates] is already the best choice? It's not related to a proxy (Gerrit could do it on its own AFAIK), so I assume so right now, however not totally sure.

@brk3
Copy link
Author

brk3 commented Apr 16, 2014

I don't feel strongly about it one way or another :) I think putting it under a gerrit namespace as you said makes sense as it keeps it separate from other attributes that may be on the node.

@hgontijo
Copy link

Thanks for adding -- ssl_cabundle_path = '' -- since the current version fails if ssl is to be installed and no ssl_cabundle_path is provided.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants