[TASK] Add coverage configuration for functional tests #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests/Functional/FunctionalTests.xml
Outdated
| <!-- | ||
| This path needs an adaption in extensions, when coverage statistics are wanted. | ||
| --> | ||
| <directory>../../../../../../typo3/sysext/*/Classes/</directory> |
There was a problem hiding this comment.
I see wee have the same path for unit tests.
Maybe I don't understand how this works, but I would expect we need to define the Classes folder of EXT:tea instead of foreign code. Maybe the comment above indicates this was copied from TYPO3 core and was not adjusted for EXT:tea and needs to be changed for unit tests as well?
Can you explain why we include the system extensions instead of our own Classes folder?
There was a problem hiding this comment.
I've done some more research: It turns out we don't need to provide any paths here - having an empty coverage node is enough to make PHPUnit happy with the configuration file.
oliverklee
force-pushed
the
task/coverage-config
branch
from
87748db to
7d0049d
Compare
We already had this for unit tests, but it was missing for functional tests. Also, we do not need to provide a path in this configuration - it suffices to have this node present in the configuration files. Closes #1078
oliverklee
force-pushed
the
task/coverage-config
branch
from
7d0049d to
dec719b
Compare
lukaszuznanski
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had this for unit tests, but it was missing for functional tests.