Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Simplify some type annotations #1590

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[TASK] Simplify some type annotations #1590

merged 1 commit into from
Feb 3, 2025

Conversation

oliverklee
Copy link
Contributor

Now that we have removed support for TYPO3 11LTS, we can simplify some type annotations.

@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Feb 3, 2025
@oliverklee oliverklee self-assigned this Feb 3, 2025
@oliverklee oliverklee marked this pull request as draft February 3, 2025 17:02
@coveralls
Copy link

coveralls commented Feb 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13118821017

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 13116461009: 0.0%
Covered Lines: 100
Relevant Lines: 100
💛 - Coveralls

@oliverklee oliverklee force-pushed the cleanup/phpstan-annotations branch from c803dba to ec3802f Compare February 3, 2025 17:04
@oliverklee
[TASK] Simplify some type annotations
63dfab6 
Now that we have removed support for TYPO3 11LTS, we can
simplify some type annotations.
@oliverklee oliverklee force-pushed the cleanup/phpstan-annotations branch from ec3802f to 63dfab6 Compare February 3, 2025 17:05
@oliverklee oliverklee marked this pull request as ready for review February 3, 2025 17:07
@DanielSiepmann DanielSiepmann merged commit 5a0baf1 into main Feb 3, 2025
37 checks passed
@DanielSiepmann DanielSiepmann deleted the cleanup/phpstan-annotations branch February 3, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSiepmann DanielSiepmann DanielSiepmann approved these changes

@linxpinx linxpinx Awaiting requested review from linxpinx

@Starkmann Starkmann Awaiting requested review from Starkmann

@lukaszuznanski lukaszuznanski Awaiting requested review from lukaszuznanski

@kanow kanow Awaiting requested review from kanow

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @DanielSiepmann