Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix GitLab CI job dependencies #1591

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[BUGFIX] Fix GitLab CI job dependencies #1591

merged 1 commit into from
Feb 4, 2025

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Feb 3, 2025 •
edited
Loading

Adapt them to the PHP linting jobs we actually run.

@oliverklee oliverklee added the bug Something isn't working label Feb 3, 2025
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Feb 3, 2025
@oliverklee oliverklee self-assigned this Feb 3, 2025
@coveralls
Copy link

coveralls commented Feb 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13132092735

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 13132073843: 0.0%
Covered Lines: 100
Relevant Lines: 100
💛 - Coveralls

@oliverklee oliverklee force-pushed the bugfix/drop-gitlab-ci-references branch from a772ec1 to 58df766 Compare February 4, 2025 08:43
@oliverklee oliverklee requested a review from Starkmann February 4, 2025 08:44
@oliverklee
[BUGFIX] Fix GitLab CI job dependencies
d4e83b4 
Adapt them to the PHP linting jobs we actually run.
@oliverklee oliverklee force-pushed the bugfix/drop-gitlab-ci-references branch from 58df766 to d4e83b4 Compare February 4, 2025 09:16
@DanielSiepmann DanielSiepmann merged commit dfc4a1b into main Feb 4, 2025
37 checks passed
@DanielSiepmann DanielSiepmann deleted the bugfix/drop-gitlab-ci-references branch February 4, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSiepmann DanielSiepmann DanielSiepmann approved these changes

@linxpinx linxpinx Awaiting requested review from linxpinx

@lukaszuznanski lukaszuznanski Awaiting requested review from lukaszuznanski

@kanow kanow Awaiting requested review from kanow

@Starkmann Starkmann Awaiting requested review from Starkmann

Assignees

@oliverklee oliverklee

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @DanielSiepmann