Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add rector/type-perfect PHPStan rules #1599

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

oliverklee
Copy link
Contributor

This package provides some opiniated PHPStan rules to make our code more explicit and easier to read.

https://github.com/rectorphp/type-perfect

As our code already is in pretty good shape, the new rules do not create any new warnings.

Also add some blank lines to the PHPStan configuration file to make it more readable.

Fixes #1335

@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Feb 16, 2025
@oliverklee oliverklee requested a review from a team February 16, 2025 11:51
@oliverklee oliverklee self-assigned this Feb 16, 2025
This package provides some opiniated PHPStan rules to make
our code more explicit and easier to read.

https://github.com/rectorphp/type-perfect

As our code already is in pretty good shape, the new rules do
not create any new warnings.

Also add some blank lines to the PHPStan configuration file to
make it more readable.

Fixes #1335
@oliverklee oliverklee force-pushed the task/enable-type-perfect branch from a2cb545 to 6522787 Compare February 19, 2025 15:17
@DanielSiepmann DanielSiepmann merged commit 16ce60f into main Feb 19, 2025
37 checks passed
@DanielSiepmann DanielSiepmann deleted the task/enable-type-perfect branch February 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try out https://github.com/rectorphp/type-perfect
2 participants