-
-
Notifications
You must be signed in to change notification settings - Fork 466
docs: add form button note #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The commit should start with |
I see, let me fix it. Thanks |
It seems to extensive now, there's also code that doesn't do anything in the examples (importing styles, adding I think going back to your original approach (short and to the point) and adding the final html/jsx code (so this |
I'm in agreement with @Pascalmh, the buttons are wrapped in Subscribe, but it's not used for anything personally I would slim it down. I'm also not certain we need the information duplicated, what do you guys think? Other than that thanks for the PR! 🤟 |
LGTM 🚀 thanks for the PR!! |
Co-authored-by: Harry Whorlow <[email protected]>
Fixes #1344
With form
<button type="reset" ... />
the native form.reset will be triggered.To prevent this behavior we can use event
preventDefault
.