-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(angular-query): injectQueries #8007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b7315dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8007 +/- ##
=========================================
+ Coverage 0 94.62% +94.62%
=========================================
Files 0 18 +18
Lines 0 279 +279
Branches 0 41 +41
=========================================
+ Hits 0 264 +264
- Misses 0 14 +14
- Partials 0 1 +1
|
That's great, finishing |
I just pulled this branch into my project since I needed the |
Thanks for your PR @Arthie. API wise this PR differs from the other adapters as these have a The other functions in the Angular adapter reactive to options such as In the result returned from these functions each property is a distinct signal, which helps with fine grained reactivity. In this PR I think we're almost there in implementing an API consistent with these principles. Feel free to contribute either in code or testing, we maintain a list of what needs to be done in the PR. |
Noticed injectQueries had yet to be fully implemented, this is my attempt to get it working.
Did some limited testing, and added simple test cases that are all passing.
Looking for feedback.