Fix: Non resolving promises created when query is not enabled#8629
Open
dev-rb wants to merge 1 commit intoTanStack:mainfrom
Open
Fix: Non resolving promises created when query is not enabled#8629dev-rb wants to merge 1 commit intoTanStack:mainfrom
dev-rb wants to merge 1 commit intoTanStack:mainfrom
Conversation
lachlancollins
force-pushed
the
main
branch
from
5d7869e to
18a12ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where extra promises that would never resolve/reject were getting created leading to infinite tab loading issues. The browser tab was forever in a "loading" state even though the actual state was resolved but the promises were still in "pending" mode.
This was the quick fix I could make to fix the issue and have everything still work as intended but I'm not sure if it's entirely correct.