Skip to content

types(vue-query): add shallow support to QueryClientConfig #8692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

types(vue-query): add shallow support to QueryClientConfig #8692

merged 3 commits into from
Apr 10, 2025

Conversation

Mini-ghost
Copy link
Contributor

Many thanks to #7733 for the great work. With that PR, we can now enable shallowReactive globally using shallow: true. However, the current type definitions might lead to confusion, making it seem like this option cannot be set globally.

This PR adds the relevant types and JSDoc to help clarify this behavior and reduce potential misunderstandings for users.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1fc705c.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 8s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 28s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-10 12:07:27 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 24, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8692

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8692

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8692

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8692

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8692

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8692

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8692

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8692

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8692

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8692

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8692

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8692

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8692

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8692

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8692

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8692

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8692

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8692

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8692

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8692

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8692

commit: 1fc705c

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.01%. Comparing base (d4f4956) to head (1fc705c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8692       +/-   ##
===========================================
+ Coverage   44.30%   71.01%   +26.71%     
===========================================
  Files         202       19      -183     
  Lines        8058      483     -7575     
  Branches     1778      136     -1642     
===========================================
- Hits         3570      343     -3227     
+ Misses       4060      110     -3950     
+ Partials      428       30      -398
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lozinsky lozinsky mentioned this pull request Mar 10, 2025
Merged
@DamianOsipiuk DamianOsipiuk merged commit 97f9625 into TanStack:main Apr 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mini-ghost @DamianOsipiuk