refactor(angular-query): change query functions to accept an options object instead of an injector #8776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object instead of an injector change query functions to accept an options object instead of an injector so that it matches angular APIs such as effect and allows adding more options in the future. BREAKING CHANGE: The injector option has been replaced with an options object. The injector can now be provided with the options object. Closes TanStack#8711
dominicbachmann
force-pushed
the
enhancement/angular-consistent-injector-options
branch
from
c5074bd to
5e63c55
Compare
|
View your CI Pipeline Execution ↗ for commit 9a3ba5a.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8776 +/- ##
===========================================
+ Coverage 44.30% 88.08% +43.78%
===========================================
Files 202 16 -186
Lines 8058 277 -7781
Branches 1778 44 -1734
===========================================
- Hits 3570 244 -3326
+ Misses 4060 32 -4028
+ Partials 428 1 -427
🚀 New features to boost your workflow:
|
arnoud-dv
reviewed
Mar 9, 2025
packages/angular-query-devtools-experimental/src/inject-devtools-panel.ts
Show resolved
Hide resolved
…-consistent-injector-options
arnoud-dv
force-pushed
the
enhancement/angular-consistent-injector-options
branch
from
953815b to
a0e033e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change query functions to accept an options object instead of an injector so that it matches angular APIs such as effect and allows adding more options in the future.
BREAKING CHANGE: The injector option has been replaced with an options object. The injector can now be provided with the options object. Closes #8711