fix(angular-query): forward queryFn errors to the NgZone#8842
Merged
arnoud-dv merged 3 commits intoTanStack:mainfrom Mar 22, 2025
Merged
fix(angular-query): forward queryFn errors to the NgZone#8842arnoud-dv merged 3 commits intoTanStack:mainfrom
arnoud-dv merged 3 commits intoTanStack:mainfrom
Conversation
Contributor
Author
|
Not sure if the extra wrapping try...catch is needed 🤔 |
Contributor
Author
|
Removed the try...catch wrappers as they were indeed redundant. |
|
View your CI Pipeline Execution ↗ for commit 066cb8f.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8842 +/- ##
===========================================
+ Coverage 46.60% 88.08% +41.47%
===========================================
Files 200 16 -184
Lines 7574 277 -7297
Branches 1741 44 -1697
===========================================
- Hits 3530 244 -3286
+ Misses 3668 32 -3636
+ Partials 376 1 -375
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any errors that occur in the queryFn or mutationnFn that should be thrown in case of
throwOnError: trueshould run in theNgZone, or else the AngularErrorHandlerwill not pick them up. A manual try...catch is needed because any errors that occur inside ofngZone.runare not automatically reported in the zone:This fixes #8839.