feat(eslint): add type-checked configuration for eslint plugin #8966
Conversation
Created a new configuration for type-checked rules in the ESLint plugin. Added a `flat/recommendedTypeChecked` config that includes the `no-void-query-fn` rule which requires TypeScript type information. Added an example project demonstrating the type-checked ESLint setup and updated the documentation to explain how to use it.
github-actions
bot
added
documentation
There was a problem hiding this comment.
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (5)
- examples/react/eslint-type-checked/.gitignore: Language not supported
- examples/react/eslint-type-checked/index.html: Language not supported
- examples/react/eslint-type-checked/package.json: Language not supported
- examples/react/eslint-type-checked/tsconfig.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/eslint-plugin-query/src/tests/no-void-query-fn.test.ts:11
- [nitpick] The naming of 'ruleTesterTypeChecked' versus the later 'ruleTester' may be confusing. Consider using consistently descriptive names to clearly differentiate tests for type-checked and non-type-checked scenarios.
const ruleTesterTypeChecked = new RuleTester({
examples/react/eslint-type-checked/eslint.config.js:15
- Verify that 'projectService' is the correct parser option to enable type-aware linting, as standard configurations often use the 'project' property. If this is a mistake, updating it may help ensure proper type-checking.
projectService: true,
|
View your CI Pipeline Execution ↗ for commit 26f5908.
☁️ Nx Cloud last updated this comment at |
|
Sizes for commit 26f5908:
|
|
@TkDodo I think something is off with the current nx configuration. It seems like |
yes, we are aware and working on it. |
|
@Newbie012 I’ve temporarily set |
…e-checked-configuration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8966 +/- ##
=======================================
Coverage 44.30% 44.30%
=======================================
Files 202 202
Lines 8058 8060 +2
Branches 1784 1776 -8
=======================================
+ Hits 3570 3571 +1
- Misses 4060 4061 +1
Partials 428 428 🚀 New features to boost your workflow:
|
…anStack/query into feat-eslint-type-checked-configuration
Created a new configuration for type-checked rules in the ESLint plugin. Added a
flat/recommendedTypeCheckedconfig that includes theno-void-query-fnrule which requires TypeScript type information. Added an example project demonstrating the type-checked ESLint setup and updated the documentation to explain how to use it.