refactor(react-router): cache outlet child lookups#6851
refactor(react-router): cache outlet child lookups#6851Sheraff wants to merge 1 commit intorefactor-signalsfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 0361303
☁️ Nx Cloud last updated this comment at |
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
Note
i'm not convinced we need this. It does yield a stable 1% client-nav improvement at the cost of more code. There might be an architecture-driven solution that would benefit all 3 adapters:
depthto each route definition, this is known at initializationSummary
childMatchIdByRouteIdderived store in the React router store factoryOutletread the next child match from that store on both the client and server instead of scanningmatchesId