refactor(vue-router): reduce Match pending churn#6855
refactor(vue-router): reduce Match pending churn#6855Sheraff merged 1 commit intorefactor-signalsfrom
Conversation
Use pendingRouteIds for route-level pending lookups so Match no longer subscribes to the full pending match id array during navigation.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 52c1e45
☁️ Nx Cloud last updated this comment at |
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
Summary
packages/vue-router/src/Match.tsxfrompendingMatchesId.includes(...)to a directpendingRouteIds[routeId]lookupObject.isequality soMatchonly reacts when that route's pending boolean changesTesting