Skip to content

fix(nx): align playwright mode build target naming#7223

Merged
beaussan merged 1 commit intomainfrom
change-build-target
Apr 18, 2026
Merged

fix(nx): align playwright mode build target naming#7223
beaussan merged 1 commit intomainfrom
change-build-target

Conversation

@beaussan
Copy link
Copy Markdown
Contributor

@beaussan beaussan commented Apr 18, 2026

Summary

  • rename inferred Playwright mode build targets to the build:<toolchain>:<mode> format
  • keep mode and shard test targets depending on the renamed build target so execution flow stays unchanged
  • align generated Nx target names with the expected mode-specific build naming convention

Summary by CodeRabbit

  • Refactor
    • Updated build target naming convention to improve consistency in the build process configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7c2fd664-c12e-4f42-9947-f9cadae872ce

📥 Commits

Reviewing files that changed from the base of the PR and between fc3b766 and 2dd0043.

📒 Files selected for processing (1)
  • scripts/nx/playwright-plugin.ts

📝 Walkthrough

Walkthrough

The Nx Playwright plugin's build target naming convention is updated from build:e2e--<toolchain>-<mode> to build:<toolchain>:<mode> in the buildModeTargets function. This changes how downstream mode targets reference their build dependencies.

Changes

Cohort / File(s) Summary
Nx Playwright Plugin Configuration
scripts/nx/playwright-plugin.ts
Updated build target name format for Playwright mode targets, changing from build:e2e--<toolchain>-<mode> to build:<toolchain>:<mode> to align with downstream dependsOn wiring conventions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A dash here, a colon there—the naming rules take flight,
Build targets dressed in finer threads, now formatted just right.
The Playwright tests shall hop with glee, their dependencies so clear,
One simple swap of syntax rules—a change we all hold dear! 🎭✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch change-build-target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 18, 2026

View your CI Pipeline Execution ↗ for commit 2dd0043

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-18 21:43:11 UTC

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@beaussan beaussan marked this pull request as ready for review April 18, 2026 21:41
@beaussan beaussan merged commit cbf9ecf into main Apr 18, 2026
6 checks passed
@beaussan beaussan deleted the change-build-target branch April 18, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant