Proposal for Channel Logging #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than one Receiver if appropriate
…at timer and wrote a test for it
|
Hi, I am sorry I didn't communicate this, but I still have some more fixes for the channel logging (do log the receive messages also for the according logger) - not committed yet - and also I found a strange problem with my JBL speaker - going back to my 'Join/Rejoin App Session' issue #161 ... For the time being, I am happy with this new version you just published. It does solve the #295 for me, thx.! |
|
Sure. I just wanted to push quickly a version with fixes on logging and heartbeat issues. More than happy to always review any changes you want to make also going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the fix for #295 and the implementation of my basic idea for the ChannelLogging.
I am not ready yet with the unittests!!! - Mocking more ILogger and more refactoring to improve the testcode ....
And I think the Logging of the Heartbeat channel could be reworked --- for production ...
I have to leave now for the weekend and will continue on Monday. Pls. Have a look and give me feedback if you like this direction or not. Thx.