readpass: reject overlong stdin and TTY passphrases - #445
Open
tokenjunkielabs wants to merge 2 commits into
Open
tokenjunkielabs wants to merge 2 commits into
tokenjunkielabs wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject passphrases which exceed the terminal/stdin read buffer instead of silently accepting a truncated prefix. The reader distinguishes an exact maximum-length line from a genuinely overlong one, drains CR-terminated input through end-of-line before confirmation, and applies the same rule to the confirmation read.
Bounty attribution
The first report was emailed to Colin before source publication. Under this repository's
AGENTS.md, any bounty is for the report rather than the patch. This pull request is not a separate bounty claim; it is the focused source carrier supporting the existing first-reporter submission.