[refac] 소셜로그인 코드 리펙토링 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkjyun
requested changes
Jul 8, 2024
| if (!isRegistered){ | ||
| User newUser = createUser( | ||
| private User loadOrCreateUser(final Platform platform, final SocialInfoDto socialInfo){ | ||
| Optional<User> existedUserOptional = userFinder.isExistedUser(platform, socialInfo.serialId()); |
There was a problem hiding this comment.
변수명 뒤에 Optional 굳이 안 붙여도 될 것 같습니다.
Comment on lines
33
to
36
|
|
||
| public Optional<User> isExistedUser(final Platform platform, final String serialId) { | ||
| return userRepository.findByPlatformAndSerialId(platform, serialId); | ||
| } |
There was a problem hiding this comment.
isExistedUser같은 메서드명은 보통 boolean형을 return할 것이라 예상 돼서
findUserByPlatFormAndSeralId는 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #21
Description ✔️
To Reviewers
다음부터 다시는 이렇게 대용량으로 pr 올리지 않겠습니다..