[feat] 식당 검색을 위한 네이버 검색 api 연결 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NaverLocationsDto locationsDto = naverFeignClient.getLocationInfo(clientId, clientSecret, query, DEFAULT_SEARCH_SIZE); | ||
| return LocationsResponse.of(locationsDto.items().stream() | ||
| .map(LocationResponse::of) | ||
| .collect(Collectors.toList())); |
There was a problem hiding this comment.
.collect(Collectors.toList())); 대신 toList()로 써도 될 것 같습니당
kgy1008
reviewed
Jul 12, 2024
|
|
||
| private final NaverFeignClient naverFeignClient; | ||
|
|
||
| public LocationsResponse getLocations(String query) { |
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class ExternalService { |
There was a problem hiding this comment.
저희 카카오나 애플 로그인도 외부 서비스여서 ExternalService보다는 네이버 검색 api를 연결하는 서비스라는 것을 들어낼 수 있도록 클래스명을 변경하는 것이 좋아보여용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #56
Description ✔️
To Reviewers