#11 [ui] 스토리텔링 뷰 작업 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-halo
requested review from
ahra1221,
pump9918,
emjayMJkim and
minemi00
minemi00
approved these changes
Jan 9, 2024
| android:viewportWidth="14" | ||
| android:viewportHeight="14"> | ||
| <path | ||
| android:pathData="M12.356,5.619C13.059,5.996 13.059,7.004 12.356,7.381L4.972,11.34C4.306,11.697 3.5,11.214 3.5,10.458L3.5,2.542C3.5,1.786 4.306,1.303 4.972,1.66L12.356,5.619Z" |
| @@ -3,7 +3,8 @@ | |||
| <style name="Base.Theme.Softie" parent="Theme.Material3.Light.NoActionBar"> | |||
| <!-- Customize your light theme here. --> | |||
| <item name="android:includeFontPadding">false</item> | |||
| <item name="android:windowLightStatusBar">true</item> | |||
There was a problem hiding this comment.
item name에 "android:statusBarColor"을 설정하고 @color/main_color
을 추가하면 상태바 색상을 마음대로 커스텀할 수 있어요~
There was a problem hiding this comment.
뷰에 따라서 색상바 색상이 바뀌어서 activity에서 바꿔주고 있습니다!
emjayMJkim
approved these changes
Jan 9, 2024
| } | ||
|
|
||
| private fun initStatusBarColor() { | ||
| window.statusBarColor = ContextCompat.getColor(this, R.color.story_telling_background) |
pump9918
approved these changes
Jan 9, 2024
| @@ -19,6 +19,21 @@ | |||
| tools:targetApi="31"> | |||
| <activity | |||
| android:name=".ui.main.MainActivity" | |||
| android:exported="false" | |||
There was a problem hiding this comment.
다들 true 놔두길래 협업할때 원칙인줄 알았는데..
근본은 false가 맞네요
| @@ -3,7 +3,8 @@ | |||
| <style name="Base.Theme.Softie" parent="Theme.Material3.Light.NoActionBar"> | |||
| <!-- Customize your light theme here. --> | |||
| <item name="android:includeFontPadding">false</item> | |||
| <item name="android:windowLightStatusBar">true</item> | |||
There was a problem hiding this comment.
item name에 "android:statusBarColor"을 설정하고 @color/main_color
을 추가하면 상태바 색상을 마음대로 커스텀할 수 있어요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_recording_20240110_003640.mp4
💬 To Reviewers