#23 [UI] 애착인형 이름 수정 뷰 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pump9918
approved these changes
Jan 10, 2024
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| super.onViewCreated(view, savedInstanceState) | ||
|
|
||
| activityViewModel = |
There was a problem hiding this comment.
viewModelProvider를 사용하는 이유가 알고 싶습니다~
There was a problem hiding this comment.
위의 게시글을 참고해보시면 다양한 viewModel 초기화 방법 중에 하나입니다!
viewModelProvider와 by viewmodels는 동일한 작업을 수행하지만, 위임을 이용한(by viewmodels) 경우, 객체가 처음 사용될 때 인스턴스화가 되기 때문에 fragment의 빠른 로드를 도와줍니다~
emjayMJkim
approved these changes
Jan 10, 2024
| companion object { | ||
| private const val NICKNAME_PATTERN = | ||
| "^[ㄱ-ㅣ가-힣a-zA-Z0-9\\u318D\\u119E\\u11A2\\u2022\\u2025a\\u00B7\\uFE55]+$" | ||
| val NICKNAME_REGEX: Pattern = Pattern.compile(NICKNAME_PATTERN) |
|
|
||
| fun checkIsNicknameValid() { | ||
| val nicknameLength = nickname.value?.length ?: 0 | ||
| _isNickNameValid.value = nicknameLength in 1..10 |
There was a problem hiding this comment.
이 부분도 companion object 빼주세용 히히 😆
minemi00
approved these changes
Jan 11, 2024
|
|
||
| val nickname: MutableLiveData<String> = MutableLiveData("") | ||
|
|
||
| var filterSpecialCharacter = InputFilter { source, _, _, _, _, _ -> |
There was a problem hiding this comment.
주어지는 반환값 중에 안쓰는 변수들은 저렇게 언더바 처리를 합니다!
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/tv_bear_naming_question" /> | ||
|
|
||
| <com.airbnb.lottie.LottieAnimationView |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_recording_20240111_024910.mp4
💬 To Reviewers