#39 [ui] 행복루틴 추가하기 상세뷰 #43

pump9918 · 2024-01-12T14:15:38Z

📑 Work Description

행복루틴 추가하기(상세) 뷰 작업
ViewPager2 사용, 양 옆 보이게 설정
인디케이터 적용

🛠️ Issue

closed [ui] 행복루틴 추가하기(상세) 뷰 #39

📷 Screenshot

Screen_Recording_20240114_183940_Softie.mp4

💬 To Reviewers

행복루틴 진행중 뷰 짜겠습니다~

…py-add-view-detail

minemi00

비율 맞추느라 고생하셨습니다!

minemi00 · 2024-01-14T10:41:57Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailActivity.kt

+        with(binding.vpHappyAddDetailCard) {
+            clipChildren = false
+            clipToPadding = false
+            offscreenPageLimit = 3


이거 제 코드에 상수로 빼둬서 가져다 쓰시면 될 것 같습니다!

오오 감사합니다!

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardViewModel.kt

stellar-halo

고생하셨습니다! 반복되는 부분들을 함수로 빼거나, 변수명 조금만 다듬어주세요~

stellar-halo · 2024-01-14T10:39:23Z

app/src/main/java/com/sopetit/softie/domain/entity/HappyCard.kt

+) {
+    data class Routines(
+        val routineId: Int,
+        @DrawableRes val cardImageUrl: Int,


꼼꼼하네요

stellar-halo · 2024-01-14T10:39:38Z

app/src/main/AndroidManifest.xml

-            android:name=".ui.main.happy.addlist.HappyAddListActivity"
-            android:exported="false"
+            android:name=".ui.happyroutine.addlist.HappyAddListActivity"
+            android:exported="true"


false로 바꿔서 올려주세요!

stellar-halo · 2024-01-14T10:39:43Z

app/src/main/AndroidManifest.xml

+
+        <activity
+            android:name=".ui.happyroutine.adddetail.HappyDetailActivity"
+            android:exported="true"


false로 바꿔서 올려주세요!

stellar-halo · 2024-01-14T10:40:00Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailActivity.kt

+        happyCard?.let {
+            binding.tvHappyAddDetailTitle.text = happyCard.name
+            binding.ivHappyAddDetailIcon.setImageResource(happyCard.iconImageUrl)
+            binding.tvHappyAddDetailSubtitle.text = happyCard.title
+            binding.tvHappyAddDetailTitle.setTextColor(Color.parseColor(happyCard.nameColor))
+        }


with(binding)으로 묶어주세요

onCreate 안이 아닌 따로 함수로 빼주세요

stellar-halo · 2024-01-14T10:41:08Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailActivity.kt

+        }
+    }
+
+    private fun moveToIng() {


moveToProgress처럼 바꿔주세요!

stellar-halo · 2024-01-14T10:44:20Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardPagerAdapter.kt

+            binding.ivHappyRoutineAddCard.setImageResource(data.cardImageUrl)
+            binding.tvHappyRoutineAddCardDetailTitle.text = data.detailTitle
+            binding.tvHappyRoutineAddCardDetailTitleBack.text = data.detailTitle
+            binding.tvHappyRoutineAddCardDetailContentBack.text = data.detailContent
+            binding.tvHappyRoutineAddCardDetailTimeBack.text = data.detailTime
+            binding.tvHappyRoutineAddCardDetailPlaceBack.text = data.detailPlace


다음 번에는 item.xml에서 data binding 써보세요! activity, fragment에서 쓰는 것처럼 코드가 간결해집니다.

with(binding) 써주세요

stellar-halo · 2024-01-14T10:47:28Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardPagerAdapter.kt

+                    binding.clHappyRoutineAddCard.visibility = View.INVISIBLE
+                    binding.clHappyRoutineAddCardBack.visibility = View.VISIBLE


이 로직은 뒷면이 보이는 로직이고
else 아래는 앞면이 보이는 로직이네요!

아래에도 공통의 로직이 있는데, 함수로 빼봅시다

오 그게 더 깔끔하겠네요 함수화하겠습니다!

stellar-halo · 2024-01-14T10:48:33Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardPagerAdapter.kt

+                if (isVisible) {
+                    binding.clHappyRoutineAddCardBack.visibility = View.INVISIBLE
+                    binding.clHappyRoutineAddCard.visibility = View.VISIBLE
+                } else {
+                    binding.clHappyRoutineAddCardBack.visibility = View.VISIBLE
+                    binding.clHappyRoutineAddCard.visibility = View.INVISIBLE


Suggested change

if (isVisible) {

binding.clHappyRoutineAddCardBack.visibility = View.INVISIBLE

binding.clHappyRoutineAddCard.visibility = View.VISIBLE

} else {

binding.clHappyRoutineAddCardBack.visibility = View.VISIBLE

binding.clHappyRoutineAddCard.visibility = View.INVISIBLE

if (isVisible) {

showCardFront()

} else {

showCardBack()

리드님 리뷰처럼 따로 함수화해주면 더 좋을 것 같습니당

stellar-halo · 2024-01-14T10:49:02Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardViewModel.kt

+    fun getHappyCardListForId(categoryId: Int): List<HappyCard> {
+        return _mockHappyCardList.value?.filter { it.categoryId == categoryId } ?: emptyList()
+    }


굿입니다!

stellar-halo · 2024-01-14T10:50:22Z

app/src/main/res/values/strings.xml

+    <string name="happy_routine_add_card_detail_title">이상형의 특성 10가지 적어보고,\n절대 포기 못할 2가지와\n나와 비슷한 3가지 찾아보기</string>
+    <string name="happy_routine_add_card_detail_content">평소에 바빠서 연락하지 못한 사람이 있다면 안부인사 개인톡을 보내 봐. 꼭 만나서 밥을 먹거나 하지 않아도 연락 한 통이 나와 그 사람을 연결하는 방법이 될 수 있어</string>
+    <string name="happy_routine_add_card_detail_time">5~10분</string>
+    <string name="happy_routine_add_card_detail_place">회사 옥상, 점심식사 후 돌아가는 길</string>


서버가 주는 값들은 tools:text로 처리한 뒤에 string으로 추출한 거 제거해주세요!

반영했습니다!!

emjayMJkim

어려웠을 텐데 정말 수고하셨습니다!!!

emjayMJkim · 2024-01-14T10:57:15Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardPagerAdapter.kt

+                if (isVisible) {
+                    binding.clHappyRoutineAddCardBack.visibility = View.INVISIBLE
+                    binding.clHappyRoutineAddCard.visibility = View.VISIBLE
+                } else {
+                    binding.clHappyRoutineAddCardBack.visibility = View.VISIBLE
+                    binding.clHappyRoutineAddCard.visibility = View.INVISIBLE


리드님 리뷰처럼 따로 함수화해주면 더 좋을 것 같습니당

emjayMJkim · 2024-01-14T11:00:42Z

app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardPagerAdapter.kt

+            onItemsTheSame = { oldItem, newItem -> oldItem.routineId == newItem.routineId },
+            onContentsTheSame = { oldItem, newItem -> oldItem.routineId == newItem.routineId }


onContentsTheSame은 { oldItem, newItem -> oldItem == newItem }으로 바꿔주세요!

onItemsTheSame = { oldItem, newItem -> oldItem.routineId == newItem.routineId }, onContentsTheSame = { oldItem, newItem -> oldItem == newItem }

좋은 지적 감사합니다~~

앗차차~ 거긴 제가 잘못했네요~

…py-add-view-detail

stellar-halo

정말Ing로 가는 거야,,?

pump9918 added 13 commits January 12, 2024 00:33

#39 [chore] happyroutine 패키지 재배치

bd7b6ce

#39 [ui] 행복 루틴 추가(상세) drawable 추가

5541606

#39 [ui] 행복 루틴 추가(상세) 뷰 작업

b4a1f9a

#39 [ui] 카드 및 상세페이지 데이터 클래스 생성

e33dcc2

#39 [ui] 행복 루틴 상세 뷰 로직

73111ed

#39 [chore] 행복 루틴 리스트 뷰와 연결

93da852

#39 [ui] 카드 뒷편 뷰 xml

8664ee5

#39 [chore] 기기대응 dimen 파일

f70c87c

#39 [fix] 카드 앞 뒷면 통합, 길이 조정

afbfacd

#39 [fix] 카드 글자 수 반응 xml 수정

54a8720

#39 [feat] 카테고리 별 데이터, 카드 연결

d593d89

#39 [fix] 세팅 정렬

95ec437

#39 [chore] CI 정렬 수정

51eb22e

pump9918 added UI ui 관련 작업 호연🐻‍❄️ 호연이가 작업함! labels Jan 14, 2024

pump9918 self-assigned this Jan 14, 2024

pump9918 added 3 commits January 14, 2024 18:52

#39 [chore] CI 정렬 재수정

bc44ccf

#39 [chore] CI 정렬 다시 수정

6389ade

Merge remote-tracking branch 'origin/develop' into feature/#39-ui-hap…

08d2a6d

…py-add-view-detail

pump9918 added the Pull Request pr 날림! label Jan 14, 2024

minemi00 approved these changes Jan 14, 2024

View reviewed changes

stellar-halo requested changes Jan 14, 2024

View reviewed changes

emjayMJkim approved these changes Jan 14, 2024

View reviewed changes

pump9918 added 4 commits January 14, 2024 21:10

#39 [chore] 서버 관계 없는 string 제거

c24fcf6

#39 [chore] 데이터 binding 함수화

99683b3

#39 [chore] 매니패스트 정상화

fb68b36

Merge remote-tracking branch 'origin/develop' into feature/#39-ui-hap…

2a56eb5

…py-add-view-detail

stellar-halo approved these changes Jan 14, 2024

View reviewed changes

pump9918 merged commit affb3f6 into develop Jan 14, 2024
1 check passed

pump9918 deleted the feature/#39-ui-happy-add-view-detail branch January 14, 2024 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#39 [ui] 행복루틴 추가하기 상세뷰 #43

#39 [ui] 행복루틴 추가하기 상세뷰 #43

pump9918 commented Jan 12, 2024 •

edited

Loading

minemi00 left a comment

minemi00 Jan 14, 2024

pump9918 Jan 14, 2024

stellar-halo left a comment

stellar-halo Jan 14, 2024

stellar-halo Jan 14, 2024

stellar-halo Jan 14, 2024

pump9918 Jan 14, 2024

stellar-halo Jan 14, 2024

stellar-halo Jan 14, 2024

stellar-halo Jan 14, 2024

stellar-halo Jan 14, 2024

stellar-halo Jan 14, 2024

pump9918 Jan 14, 2024

stellar-halo Jan 14, 2024

emjayMJkim Jan 14, 2024

stellar-halo Jan 14, 2024

stellar-halo Jan 14, 2024

pump9918 Jan 14, 2024

emjayMJkim left a comment

emjayMJkim Jan 14, 2024

emjayMJkim Jan 14, 2024

pump9918 Jan 14, 2024

stellar-halo Jan 14, 2024

stellar-halo left a comment

		binding.clHappyRoutineAddCard.visibility = View.INVISIBLE
		binding.clHappyRoutineAddCardBack.visibility = View.VISIBLE

		onItemsTheSame = { oldItem, newItem -> oldItem.routineId == newItem.routineId },
		onContentsTheSame = { oldItem, newItem -> oldItem.routineId == newItem.routineId }

#39 [ui] 행복루틴 추가하기 상세뷰 #43

#39 [ui] 행복루틴 추가하기 상세뷰 #43

Conversation

pump9918 commented Jan 12, 2024 • edited Loading

📑 Work Description

🛠️ Issue

📷 Screenshot

💬 To Reviewers

minemi00 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellar-halo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emjayMJkim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellar-halo left a comment

Choose a reason for hiding this comment

pump9918 commented Jan 12, 2024 •

edited

Loading