#42 [feat] 데일리 루틴 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pump9918
approved these changes
Jan 14, 2024
| viewModel.isEditBtnEnabled.observe(viewLifecycleOwner) { isBtnEnabled -> | ||
| if (isBtnEnabled) { | ||
| binding.btnDailyRoutineDelete.setOnClickListener { | ||
| BindingBottomSheet.Builder().build( |
There was a problem hiding this comment.
Builder( )함수는 어떤 역할을 하나요??
There was a problem hiding this comment.
builder 패턴은 필요한 parameter만 설정해두면 build 메소드를 통해 객체를 생성할 수 있습니다..! 여기서 제가 공통 바텀시트를 만들어 두어서 이 builder 패턴을 통해서 각 뷰에서 커스텀되는 parameter만 넣어주면 바텀시트를 생성할 수 있습니다!!
There was a problem hiding this comment.
빌더 패턴까지 사용하시다니 정말 대단하군요 디자인패턴 공부 많이 한게 느껴졌어요. 저희꺼 바텀시트도 빌더로 만들어주세요 !!
| binding.tvDailyRoutineEdit.setOnClickListener { | ||
| val intent = Intent(requireActivity(), DailyRoutineEditActivity::class.java) | ||
| startActivity(intent) | ||
| private fun initSetDailyRoutineContent() { |
There was a problem hiding this comment.
코드가 직관적이여서 이해하기 쉽고 좋아요^^
minemi00
approved these changes
Jan 14, 2024
Comment on lines
37
to
44
| private fun routineItemView(routineTitle: TextView, achieveMsg: TextView, index: Int) { | ||
| viewModel.mockDailyRoutineList.observe(viewLifecycleOwner) { dailyRoutineList -> | ||
| val achieveCountMsg = | ||
| getString(R.string.daily_routine_ing).format(dailyRoutineList[index].achieveCount) | ||
| achieveMsg.text = achieveCountMsg | ||
| routineTitle.text = dailyRoutineList[index].content | ||
| } | ||
| } |
There was a problem hiding this comment.
루틴이 며칠째 달성중인지 알려주는 코드를 어떻게 짜야할지 고민했었는ㄴ데 이런식이군요 ....
| val routineAddList = listOf<Int>(1, 2) | ||
| // val routineAddList = listOf<Int>(1, 2) | ||
|
|
||
| private val _mockDailyRoutineList: MutableLiveData<List<DailyRoutine>> = MutableLiveData( |
stellar-halo
approved these changes
Jan 14, 2024
|
|
||
| private fun initSetDeleteView() { | ||
| viewModel.isDeleteView.observe(viewLifecycleOwner) { isDeleteView -> | ||
| if (!isDeleteView) { |
There was a problem hiding this comment.
if문 안에는 ! 연산자를 넣지 않는 것이 좋다고 합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
feat.daily.routine.edit.finish.mp4
💬 To Reviewers
커스텀 스낵바를 만들었는데 위치를 bottom navi 위로 올려야 하는데 방법이 생각이 안나서 일단 위치 계산해서 넣었습니다(좋은 방법 있으면 알려주세요ㅜ)
'완료하기' 버튼 클릭시 바텀시트 이미지에 해당 데일리 루틴의 이미지 넣는 것은 서버통신 붙이면서 연결하겠습니다 (지금은 그냥 drawable 이미지로 넣었습니다)