#54 [ui] 행복루틴 삭제하기 뷰 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py-delete-view # Conflicts: # app/src/main/res/values/strings.xml
stellar-halo
requested changes
Jan 15, 2024
| android:layout_marginEnd="20dp" | ||
| android:layout_marginBottom="34dp" | ||
| android:background="@drawable/shape_red_fill_12_rect" | ||
| android:text="루틴을 삭제할래" |
…py-delete-view # Conflicts: # app/src/main/java/com/sopetit/softie/ui/happyroutine/progress/HappyProgressFragment.kt
stellar-halo
requested changes
Jan 16, 2024
| isDrawable = true, | ||
| imageDrawable = R.drawable.ic_bear_face_crying, | ||
| imageUri = "", | ||
| title = "정말 삭제할까요?", |
| doBtnAction = { | ||
| snackBar( | ||
| binding.root.rootView, | ||
| "행복루틴을 삭제했어요" |
Comment on lines
105
to
106
| binding.btnHappyProgressClear.setOnClickListener { | ||
| } |
There was a problem hiding this comment.
혹시 이 친구는 setOnClickListener안에 아무것도 없는데 왜 써주신 건가요?
There was a problem hiding this comment.
버튼을 누르면 바텀시트를 실행시킬 예정으로 비워둔 부분인데, 함수를 사용해서 없어진 부분을 고려못했습니다. 지금 수정하겠습니다!
…ui-happy-delete-view # Conflicts: # app/src/main/java/com/sopetit/softie/di/RepositoryModule.kt # app/src/main/java/com/sopetit/softie/di/RetrofitServiceModule.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_recording_20240117_002127.mp4
💬 To Reviewers