Skip to content

Commit

Permalink
Merge pull request #367 from Team-Sopetit/refactor/#366/chan
Browse files Browse the repository at this point in the history
[REFACTOR] 메이커 루틴 제거
  • Loading branch information
Chan531 authored Dec 19, 2024
2 parents ae5a488 + c202029 commit 62ed503
Show file tree
Hide file tree
Showing 20 changed files with 5 additions and 368 deletions.
32 changes: 0 additions & 32 deletions src/main/java/com/soptie/server/api/controller/MakerApi.java

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ public enum SuccessMessage {
/* challenge */
GET_CHALLENGE("도전루틴 조회 성공"),

/* maker */
SUCCESS_GET_MAKER_THEME("메이커 테마 조회 성공"),

/* memo */
CREATE_MEMO("메모 생성 성공"),
UPDATE_MEMO("메모 수정 성공"),
Expand Down
17 changes: 0 additions & 17 deletions src/main/java/com/soptie/server/domain/maker/Maker.java

This file was deleted.

23 changes: 0 additions & 23 deletions src/main/java/com/soptie/server/domain/maker/MakerService.java

This file was deleted.

30 changes: 0 additions & 30 deletions src/main/java/com/soptie/server/domain/maker/Tags.java

This file was deleted.

5 changes: 2 additions & 3 deletions src/main/java/com/soptie/server/domain/theme/Theme.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ public class Theme {
@NotNull
private String description;
private int sequence;
private Long makerId;

@Override
public boolean equals(Object obj) {
Expand All @@ -30,11 +29,11 @@ public boolean equals(Object obj) {
Theme theme = (Theme)obj;
return sequence == theme.sequence && Objects.equals(id, theme.id) && Objects.equals(name,
theme.name) && Objects.equals(comment, theme.comment) && Objects.equals(description,
theme.description) && Objects.equals(makerId, theme.makerId);
theme.description);
}

@Override
public int hashCode() {
return Objects.hash(id, name, comment, description, sequence, makerId);
return Objects.hash(id, name, comment, description, sequence);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,4 @@ public GetThemesResponse getBasicThemes() {
val themes = themeAdapter.findByBasic();
return GetThemesResponse.of(themes);
}

public Theme acquireById(long themeId) {
return themeAdapter.findById(themeId);
}
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import java.util.List;

import com.soptie.server.api.controller.dto.response.maker.MakerThemeResponse;
import com.soptie.server.common.exception.ExceptionCode;
import com.soptie.server.common.exception.SoftieException;
import com.soptie.server.common.support.RepositoryAdapter;
Expand All @@ -19,15 +18,11 @@ public class ThemeAdapter {
private final ThemeRepository themeRepository;

public List<Theme> findByBasic() {
return themeRepository.findByMakerIdIsNullOrderBySequenceAsc()
return themeRepository.findByOrderBySequenceAsc()
.stream().map(ThemeEntity::toDomain)
.toList();
}

public List<MakerThemeResponse> findAllWithMaker() {
return themeRepository.findAllWithMaker();
}

public Theme findById(long id) {
return find(id).toDomain();
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ public class ThemeEntity extends BaseEntity {
private String description;
@Column(nullable = false)
private int sequence;
private Long makerId;

public Theme toDomain() {
return Theme.builder()
Expand All @@ -26,7 +25,6 @@ public Theme toDomain() {
.comment(this.comment)
.description(this.description)
.sequence(this.sequence)
.makerId(this.makerId)
.build();
}
}

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

import com.soptie.server.persistence.entity.ThemeEntity;

public interface ThemeRepository extends JpaRepository<ThemeEntity, Long>, ThemeCustomRepository {
List<ThemeEntity> findByMakerIdIsNullOrderBySequenceAsc();
public interface ThemeRepository extends JpaRepository<ThemeEntity, Long> {
List<ThemeEntity> findByOrderBySequenceAsc();

List<ThemeEntity> findByIdIn(List<Long> ids);
}
Loading

0 comments on commit 62ed503

Please sign in to comment.