WIP: Update to Material UI Search Bar#112
Open
SnekCode wants to merge 34 commits intoTeamWertarbyte:masterfrom
Open
WIP: Update to Material UI Search Bar#112SnekCode wants to merge 34 commits intoTeamWertarbyte:masterfrom
SnekCode wants to merge 34 commits intoTeamWertarbyte:masterfrom
Conversation
updated license
Create LICENSE
Fix/ts conversion
Feat/storybook
unit test for search bar
adding CI/CD
…ft or right, search button will no longer disappear if a onRequestSearch function is provided, clearbutton no uses display none when hidding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project fully converted to typescript
Added unit test to verify functionality
Updated dependancies fixing #99, tested with nextjs app using react 17+
Added order props to address #84
Added checks to prevent search icon hiding when a onRequestSearch function is available fixes #86 #106
WIP because much of the changes may not be needed upstream.