skipping UNKNOWN1 causes massive issues #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should probably be renamed to something like mUVTransforms in the future
|
How did you port that in Blender? |
|
|
That looks cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand UNKNOWN1 is the size of UV Transforms block, and wasn't utilized in TWD games (size 0). But in Sam&Max remasters I'm working with it's used quite often. For now I'm just skipping the blocks (size 20 = Int32+4xFloat32) but you should probably make appropriate vectors. I'm not too knowledgeable in the code base for that.
This should probably be renamed to something like mUVTransforms in the future too
So far I can only verify that the converter is reading data correctly, by comparing vert counts and objects/MeshBatches count
