feat: support bug detection related to isolation level #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello, I am one of the code reviewers. Can you translate your pr title, description, commit messages to English? And we recommend using this format to title your PR. |
|
you can use "feat: support bug detection related to isolation level", and please add the issues you resolved in description. |
Tang-Kin-Long
changed the title
Okay! |
style: Update contents in docstring to maintain function description of mda_detect.py.
I have made the expected modification, please check, thank you. |
hldgs
reviewed
Jul 25, 2024
|
do you test your commit on all dbmss? |
No, I haven't installed Docker and configured the test environment. I am trying to do that. |
hldgs
reviewed
Jul 30, 2024
This program adds a determination function to detect test cases in MySQL environment. For now, only "serializable" isolation level is supported. Other isolation levels and dbms environments will be added later. The output result passes almost all test cases, except "iat_dda_write_skew_predicate_based-overdraft_protection", because its variable declaration is quite different.
This program adds a determination function to detect test cases in MySQL environment. For now, "repeatable-read" and "serializable" isolation levels are supported. Other isolation levels and dbms environments will be added later. The output result passes almost all test cases, except "rat_mda_step_rat_predicate_based_insert", because it uses "sum" function so an improved syntax analysis is required.
This program adds two determination functions to detect test cases in MySQL environment. For now, ALL isolation levels in MySQL are supported. Other dbms environments will be added if needed. The output result passes almost all test cases, except: SERIALIZABLE: "iat_dda_write_skew_predicate_based-overdraft_protection"; REPEATABLE-READ: "rat_mda_step_rat_predicate_based_insert"; READ-COMMITTED: None; READ-UNCOMMITTED: "iat_dda_write_skew_predicate_based-intersecting_data"; These cases use irregular expression like "sum" function, self-defined table name or attribute query, so the more complex syntax analysis is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support bug detection related to isolation level
resolve the issue: bug detection related to isolation level
Modify parts of code in Coo consistency check to realize the error detection result output of related isolation level.
Reference the test data as well.
Sample Output:
--------file:rr_s_s_avoid--------
Transaction 1:-----repeatable-read-----
Error Detection: No error in this isolation level.
Transaction 2:-----serializable-----
Edge(begin_time=4, type=ICR, out=3)
Error Detection: Phantom-Read
Transaction 3:-----serializable-----
Error Detection: No error in this isolation level.
---------------------------------#