Merged
Conversation
added 2 commits
February 18, 2025 09:21
This commit extracts PortManagerTest.ListAppender into ConnectedListAppender and moves it into terracotta-utilities-test-tools. # Conflicts: # port-chooser/src/test/java/org/terracotta/utilities/test/net/PortManagerTest.java
When used on Windows, it is possible for NetStat to observe ports for which the short command is missing. This commit corrects the resulting failure.
982c060 to
db6bafb
Compare
Contributor
Author
|
Updated to correct some test failures -- neglected to synchronize appender access. |
chrisdennis
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.